Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch error in _relevant_cdk_files_are_present #7210

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Jun 28, 2024

Which issue(s) does this change fix?

#6756

Why is this change necessary?

To prevent unlikely error from os.listdir(os.getcwd()) to break telemetry

How does it address the issue?

In _relevant_cdk_files_are_present, catch the FileNotFoundError and return False

What side effects does this change have?

No

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau requested a review from a team as a code owner June 28, 2024 21:37
@hawflau hawflau requested review from lucashuy and jysheng123 June 28, 2024 21:37
@hawflau hawflau enabled auto-merge June 28, 2024 21:58
@hawflau hawflau added this pull request to the merge queue Jun 28, 2024
Merged via the queue into develop with commit 80e733f Jun 28, 2024
57 checks passed
@hawflau hawflau deleted the fix-6756 branch June 29, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants